pr comments

rerun-io · Oct 19, 2023 · 80b056d · 80b056d
1 parent 0a3a15b
commit 80b056d
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 7 deletions.
diff --git a/crates/re_arrow_store/src/store_gc.rs b/crates/re_arrow_store/src/store_gc.rs
@@ -373,7 +373,7 @@ impl DataStore {
         self.timeless_tables.retain(|_, table| {
             // If any column is non-empty, we need to keep this table
             for num in &table.col_num_instances {
-                if num != &0.into() {
+                if num.get() != 0 {
                     return true;
                 }
             }
@@ -395,7 +395,7 @@ impl DataStore {
             for bucket in table.buckets.values() {
                 let inner = bucket.inner.read();
                 for num in &inner.col_num_instances {
-                    if num != &0.into() {
+                    if num.get() != 0 {
                         return true;
                     }
                 }

diff --git a/crates/re_log_types/src/num_instances.rs b/crates/re_log_types/src/num_instances.rs
@@ -17,12 +17,14 @@ impl NumInstances {
 }
 
 impl From<NumInstances> for u32 {
+    #[inline]
     fn from(val: NumInstances) -> Self {
         val.0
     }
 }
 
 impl From<u32> for NumInstances {
+    #[inline]
     fn from(value: u32) -> Self {
         Self(value)
     }

diff --git a/crates/re_types/definitions/rerun/datatypes/uint32.fbs b/crates/re_types/definitions/rerun/datatypes/uint32.fbs
@@ -5,7 +5,7 @@ include "rust/attributes.fbs";
 
 namespace rerun.datatypes;
 
-/// A 32bit integer.
+/// A 32bit unsigned integer.
 struct UInt32 (
   "attr.arrow.transparent",
   "attr.rust.derive": "Copy, PartialEq, Eq, PartialOrd, Ord",

diff --git a/crates/re_types_core/src/datatypes/uint32.rs b/crates/re_types_core/src/datatypes/uint32.rs
diff --git a/docs/content/reference/types/datatypes/uint32.md b/docs/content/reference/types/datatypes/uint32.md
diff --git a/rerun_cpp/src/rerun/datatypes/uint32.hpp b/rerun_cpp/src/rerun/datatypes/uint32.hpp
diff --git a/rerun_py/rerun_sdk/rerun/datatypes/uint32.py b/rerun_py/rerun_sdk/rerun/datatypes/uint32.py