Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(make): improve generate cmd for go mod #1699

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(make): improve generate cmd for go mod #1699

merged 1 commit into from
Dec 2, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Dec 2, 2024 •
edited
Loading

Description, Motivation and Context

  • solve make generate only works with GOPATH

Demo PR: #1700
This demo show if you change a scheme like add GenerateTest field in pkg/apis/troubleshoot/v1beta2/hostcollector_shared.go

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan added the type::feature New feature or request label Dec 2, 2024
@DexterYan DexterYan requested a review from a team as a code owner December 2, 2024 02:48
@DexterYan DexterYan merged commit de15d02 into main Dec 2, 2024
23 checks passed
@DexterYan DexterYan deleted the dx/sc-116668/improve-make-generate branch December 2, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavpaice xavpaice xavpaice approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DexterYan @xavpaice