Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure Copy collector run last #1688

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat: ensure Copy collector run last #1688

merged 2 commits into from
Nov 14, 2024
+104 −0

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Nov 13, 2024 •
edited
Loading

Description, Motivation and Context

Story: https://app.shortcut.com/replicated/story/115284/support-bundle-collector-to-support-order-of-execution
Demo: https://asciinema.org/a/okCHqJIFtb3KZQZqU7OT4KMdt

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@nvanthao nvanthao added the type::feature New feature or request label Nov 13, 2024
@nvanthao nvanthao requested a review from a team as a code owner November 13, 2024 02:20
@nvanthao nvanthao mentioned this pull request Nov 13, 2024
Closed
6 tasks
@nvanthao nvanthao force-pushed the gerard/sc-115284/copy branch from 2e9878a to b069b1f Compare November 13, 2024 02:25
@nvanthao nvanthao force-pushed the gerard/sc-115284/copy branch from c4c04bc to 1121e83 Compare November 13, 2024 22:42
@nvanthao nvanthao merged commit 7bb88e6 into main Nov 14, 2024
24 checks passed
@nvanthao nvanthao deleted the gerard/sc-115284/copy branch November 14, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DexterYan DexterYan DexterYan approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvanthao @DexterYan