Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): add local host support bundle test #1680

Merged
merged 5 commits into from
Nov 8, 2024
Merged

feat(e2e): add local host support bundle test #1680

merged 5 commits into from
Nov 8, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Nov 8, 2024 •
edited
Loading

Description, Motivation and Context

  • add local host support bundle test
  • add preflight e2e go test

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan added the type::feature New feature or request label Nov 8, 2024
@DexterYan DexterYan requested a review from a team as a code owner November 8, 2024 00:47
nvanthao
nvanthao requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 nit

test/e2e/support-bundle/host_local_collector_e2e_test.go Outdated Show resolved Hide resolved
nvanthao
nvanthao approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DexterYan DexterYan merged commit 40eef3c into main Nov 8, 2024
27 checks passed
@DexterYan DexterYan deleted the dx/add-e2e-test branch November 8, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanthao nvanthao nvanthao approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DexterYan @nvanthao