Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Copy syslog files from host if they exist #95

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Jul 12, 2024

No description provided.

@banjoh banjoh requested a review from adamancini July 12, 2024 15:18
@adamancini
Copy link
Member

my only suggestion would be that not all systems call the syslog "syslog" like I think on some systems it might be /var/log/messages - otherwise LGTM

@adamancini
Copy link
Member

actually, I'm doing a little more reading and I don't think messages file is relevant anymore

@adamancini
Copy link
Member

@banjoh maybe we should also grab something like journalctl --no-pager --output=short-iso to grab everything from journald

@banjoh
Copy link
Member Author

banjoh commented Jul 12, 2024

my only suggestion would be that not all systems call the syslog "syslog" like I think on some systems it might be /var/log/messages - otherwise LGTM

I'll merge and follow up with another PR

@banjoh banjoh merged commit a78a7c0 into replicatedhq:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants