support managed SDK deployment #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodonnell
changed the title
cbodonnell
changed the title
cbodonnell
force-pushed
the
cbo/sc-88171/managed-by
branch
6 times, most recently
from
b27734c to
7603a61
Compare
cbodonnell
changed the title
cbodonnell
force-pushed
the
cbo/sc-88171/managed-by
branch
from
cd17b0a to
1dbb42b
Compare
sgalsaleh
reviewed
Sep 28, 2023
sgalsaleh
reviewed
Sep 28, 2023
sgalsaleh
previously approved these changes
Sep 28, 2023
cbodonnell
force-pushed
the
cbo/sc-88171/managed-by
branch
from
c23d5be to
c52c394
Compare
sgalsaleh
reviewed
Oct 5, 2023
sgalsaleh
reviewed
Oct 5, 2023
sgalsaleh
reviewed
Oct 5, 2023
sgalsaleh
reviewed
Oct 5, 2023
sgalsaleh
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
userAgent,replicatedID, andappIDvalues that will enable support for "managed" SDK deployments. Another application can set these values when deploying the SDK so that it will report on behalf of that application using the same instance ids and user-agent.This PR also exposes an
airgapvalue to run the SDK in airgap mode by settingDISABLE_OUTBOUND_CONNECTIONS=trueWhich issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/88171/detect-and-configure-the-replicated-sdk-chart-subchart-if-it-s-part-of-the-vendor-s-application
Special notes for your reviewer:
There was a decent chunk of refactoring needed within the
bootstraplogic to support setting these valuesSteps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?