Ingress will only have an IP address when type is LoadBalancer #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
force-pushed
the
divolgin/sc-113505/sdk-falsely-reporting-ingress-as-unavailable
branch
from
e9a4a60 to
4fde9d4
Compare
sgalsaleh
approved these changes
Dec 16, 2024
divolgin
deleted the
divolgin/sc-113505/sdk-falsely-reporting-ingress-as-unavailable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When application includes an Ingress, without a LoadBalancer ingress will not have an address associated with it. While this can be a valid setup, it will always result in application as being unavailable.
Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/113505/sdk-falsely-reporting-ingress-as-unavailable-when-it-should-not
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?