Handle bad metadata secret values gracefully #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandemicsyn
previously approved these changes
Dec 6, 2024
pandemicsyn
approved these changes
Dec 9, 2024
divolgin
deleted the
divolgin/sc-117030/replicated-sdk-fails-to-report-custom-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If metadata secret becomes malformed, reporting custom metrics will start failing and will not recover on its own. When the secret or the data are malformed, the API should continue to function.
Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/117030/replicated-sdk-fails-to-report-custom-metrics-if-the-latest-custom-metrics-key-is-not-there
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE