feedback

.github/actions/validate-endpoints/action.yml

@@ -8,10 +8,6 @@ inputs:
     description: 'License fields to validate'
     required: false
     default: '[]'
-  version-label:
-    description: 'Version label to validate'
-    required: false
-    default: ''
   integration-enabled:
     description: 'If integration mode is enabled or not'
     required: false
@@ -91,8 +87,6 @@ runs:
 
     - name: Validate /app/info endpoint
       shell: bash
-      env:
-        VERSION_LABEL: ${{ inputs.version-label }}
       run: |
         appStatus=$(curl -s --fail --show-error localhost:8888/api/v1/app/info | jq -r .appStatus | tr -d '\n')
 
@@ -101,15 +95,6 @@ runs:
           exit 1
         fi
 
-        if [ -n "$VERSION_LABEL" ]; then
-          versionLabel=$(curl -s --fail --show-error localhost:8888/api/v1/app/info | jq -r .currentRelease.versionLabel | tr -d '\n')
-
-          if [ "$versionLabel" != "$VERSION_LABEL" ]; then
-            echo "Expected version label to be '$VERSION_LABEL', but is '$versionLabel'."
-            exit 1
-          fi
-        fi
-
     - name: Validate /app/updates endpoint
       shell: bash
       run: |

.github/workflows/main.yaml

@@ -272,12 +272,16 @@ jobs:
         run: |
           helm upgrade test-chart oci://registry.replicated.com/$APP_SLUG/$CHANNEL_SLUG/test-chart --set replicated.integration.enabled=false --set replicated.versionLabel=1.0.0 --wait --timeout 2m
 
+      - name: Validate replicated upgrade
+        run: |
+          # validate the deployment revision is 2
+          kubectl get deploy/replicated -o jsonpath='{.metadata.annotations.deployment\.kubernetes\.io/revision}' | grep -q 2
+
       - name: Validate endpoints
         uses: ./.github/actions/validate-endpoints
         with:
           license-id: ${{ env.LICENSE_ID }}
           license-fields: ${{ env.LICENSE_FIELDS }}
-          version-label: '1.0.0'
           integration-enabled: 'false'
 
       - name: Uninstall test-chart via Helm