Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm-install): registry login not required #68

Merged
merged 2 commits into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions archive-channel/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion archive-channel/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions archive-customer/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion archive-customer/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions create-cluster/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion create-cluster/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions create-customer/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion create-customer/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions create-object-store/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion create-object-store/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions create-postgres/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion create-postgres/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions create-release/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion create-release/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions expose-port/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion expose-port/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions helm-install/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ run_preflights ---> install_a_helm_chart_to_a_cluster
| --- | --- | --- | --- |
| helm-path | | True | The path to the helm binary to use |
| kubeconfig | | True | A valid kubeconfig to connect to |
| registry-username | | True | The registry username to log in with |
| registry-password | | True | The registry password to use |
| registry-username | | False | The registry username to log in with |
| registry-password | | False | The registry password to use |
| repo-name | | False | The repo name to use (when not installing from local or oci) |
| repo-url | | False | The repo url to use (when not installing from local or oci) |
| chart | | True | The chart to use |
Expand Down
4 changes: 2 additions & 2 deletions helm-install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ inputs:
required: true
registry-username:
description: "The registry username to log in with"
required: true
required: false
registry-password:
description: "The registry password to use"
required: true
required: false
repo-name:
description: "The repo name to use (when not installing from local or oci)"
required: false
Expand Down
4 changes: 2 additions & 2 deletions helm-install/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion helm-install/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions kots-install/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion kots-install/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions prepare-cluster/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion prepare-cluster/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions remove-cluster/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion remove-cluster/dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/helm-install/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ export async function actionHelmInstall() {
const helmPath: string = core.getInput("helm-path", { required: true });
const kubeconfig: string = core.getInput("kubeconfig", { required: true });
const namespace: string = core.getInput("namespace", { required: true }) || "default";
const registryUsername: string = core.getInput("registry-username", { required: true });
const registryPassword: string = core.getInput("registry-password", { required: true });
const registryUsername: string = core.getInput("registry-username");
const registryPassword: string = core.getInput("registry-password");
const runPreflights: boolean = core.getBooleanInput("run-preflights");
const values: string = core.getInput("values");
const repoName: string = core.getInput("repo-name");
Expand Down
Loading