chore(ci): more e2e tests #63
Conversation
| kots-config-values: | | ||
| apiVersion: kots.io/v1beta1 | ||
| kind: ConfigValues | ||
| metadata: | ||
| name: nginx | ||
| spec: | ||
| values: | ||
| api_token: | ||
| value: r8yWQ/cUeLVprKGKZb2gpE5IcQ0Tep1iaNwn7078 | ||
| example_default_value: | ||
| default: please change this value | ||
| value: testing | ||
| hidden_text: | ||
| value: lPiIJL1RfL4v/YKzHfnx/9HyR2x4t5wnVxSLmzJlmf12HlqlyBoSfnvd0O+mftiT8h0+kumsBqc= | ||
| readonly_text_left: | ||
| value: 8WIAQHZW_G | ||
| show_text_inputs: | ||
| default: "0" | ||
| value: "1" |
There was a problem hiding this comment.
Does this have to be inline? If so, I assume we should improve the kots install action
There was a problem hiding this comment.
I guess it can be a file, so maybe here just use the file (avoiding duplication)
There was a problem hiding this comment.
I made it inline for more coverage since it supports both. I also wasnt sure how the env var would behave with a multi line string.
| kubernetes-distribution: kind | ||
| timeout-minutes: 5 | ||
|
|
||
| - name: test expose-port |
There was a problem hiding this comment.
Idea: before exposing a port, run a kubectl apply and install nginx with a nodeport service.
After expose-port, verify with curl the exposed port.
Or would this be beyond testing the action?
There was a problem hiding this comment.
We test this in cmx e2e tests
| - name: test archive-channel | ||
| id: archive-channel | ||
| uses: ./archive-channel | ||
| with: | ||
| api-token: ${{ secrets.REPLICATED_API_TOKEN }} | ||
| app-slug: replicated-actions-ci # from the Replicated QA team | ||
| channel-slug: ${{ steps.create-release.outputs.channel-slug }} | ||
|
|
||
| - name: archive-channel | ||
| if: always() | ||
| uses: replicatedhq/compatibility-actions/archive-channel@v1 | ||
| continue-on-error: true # It could be that the channel is already removed | ||
| with: | ||
| api-token: ${{ secrets.REPLICATED_API_TOKEN }} | ||
| app-slug: replicated-actions-ci # from the Replicated QA team | ||
| channel-slug: ${{ steps.create-release.outputs.channel-slug }} |
There was a problem hiding this comment.
If archive-channel is broken, this will result in orphaned channels.
There was a problem hiding this comment.
This is from the stable branch replicatedhq/compatibility-actions/archive-channel@v1 to avoid orphaned channels. see on line 44 is the actual test
| const name: string = core.getInput('name'); | ||
| const helmPath: string = core.getInput("helm-path", { required: true }); | ||
| const kubeconfig: string = core.getInput("kubeconfig", { required: true }); | ||
| const namespace: string = core.getInput("namespace", { required: true }) || "default"; |
There was a problem hiding this comment.
How does this work, if it is required and has a default?
There was a problem hiding this comment.
I'm not sure its possible but i feel like it cant hurt
No description provided.