use context in k8s function calls

replicatedhq · Aug 1, 2024 · f9d22f3 · f9d22f3
1 parent 71a7bdb
commit f9d22f3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cmd/outdated/cli/root.go b/cmd/outdated/cli/root.go
@@ -60,7 +60,7 @@ func RootCmd() *cobra.Command {
 				finishedCh <- true
 			}()
 
-			images, err := o.ListImages(KubernetesConfigFlags, foundImageName, v.GetStringSlice("ignore-ns"))
+			images, err := o.ListImages(cmd.Context(), KubernetesConfigFlags, foundImageName, v.GetStringSlice("ignore-ns"))
 			if err != nil {
 				log.Error(err)
 				log.Info("")

diff --git a/pkg/outdated/list.go b/pkg/outdated/list.go
@@ -1,6 +1,7 @@
 package outdated
 
 import (
+	"context"
 	"fmt"
 	"strings"
 
@@ -20,7 +21,7 @@ type RunningImage struct {
 	PullableImage string
 }
 
-func (o Outdated) ListImages(configFlags *genericclioptions.ConfigFlags, imageNameCh chan string, ignoreNs []string) ([]RunningImage, error) {
+func (o Outdated) ListImages(ctx context.Context, configFlags *genericclioptions.ConfigFlags, imageNameCh chan string, ignoreNs []string) ([]RunningImage, error) {
 	config, err := configFlags.ToRESTConfig()
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to read kubeconfig")
@@ -31,7 +32,7 @@ func (o Outdated) ListImages(configFlags *genericclioptions.ConfigFlags, imageNa
 		return nil, errors.Wrap(err, "failed to create clientset")
 	}
 
-	namespaces, err := clientset.CoreV1().Namespaces().List(metav1.ListOptions{})
+	namespaces, err := clientset.CoreV1().Namespaces().List(ctx, metav1.ListOptions{})
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to list namespaces")
 	}
@@ -44,7 +45,7 @@ func (o Outdated) ListImages(configFlags *genericclioptions.ConfigFlags, imageNa
 
 		imageNameCh <- fmt.Sprintf("%s/", namespace.Name)
 
-		pods, err := clientset.CoreV1().Pods(namespace.Name).List(metav1.ListOptions{})
+		pods, err := clientset.CoreV1().Pods(namespace.Name).List(ctx, metav1.ListOptions{})
 		if err != nil {
 			return nil, errors.Wrap(err, "failed to list pods")
 		}