Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading dependencies #1042

Closed
wants to merge 2 commits into from
Closed

Upgrading dependencies #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2be3ef
Upgrading dependencies
jtuchscherer Nov 9, 2024
da33d57
Fixing the gha scripts to not use yarn anymore Also making the Makefi…
Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
cache: yarn
node-version: 22.11.0
cache: npm

- name: build
run: make deps build-staging
Expand All @@ -44,8 +44,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
cache: yarn
node-version: 22.11.0
cache: npm

- name: build
run: make deps build-production
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/preview.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
cache: yarn
node-version: 22.11.0
cache: npm

- name: build
run: make deps build-staging
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
cache: yarn
node-version: 22.11.0
cache: npm
- run: make deps test
13 changes: 8 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,26 @@ PROJECT_NAME ?= kurl-sh
clean:
rm -rf node_modules
rm -rf dist
rm -rf .cache

.PHONY: deps
deps:
yarn --silent --frozen-lockfile
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true \
npm ci

.PHONY: test
test:
yarn run test
npm run test

.PHONY: serve
serve: deps
yarn start
GOOGLE_ANALYTICS_TRACKING_ID=dummy \
npm run start

.PHONY: build-staging
build-staging:
yarn build-staging
npm run build-staging

.PHONY: build-production
build-production:
yarn build
npm run build
Loading
Loading