Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping pact tests for replicated.app #4882

Merged

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Sep 12, 2024

What this PR does / why we need it:

This bootstraps Pact consumer for replicated.app.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/110520/add-test-for-unauthenticated-200-response-from-https-replicated-app

Does this PR require a test?

NONE

Does this PR require a release note?


Does this PR require documentation?

@divolgin divolgin added the type::feature New feature or request label Sep 12, 2024
@divolgin divolgin marked this pull request as ready for review September 12, 2024 00:18
@divolgin divolgin force-pushed the divolgin/sc-110520/add-test-for-unauthenticated-200-response branch from e38acdd to b1e98ff Compare September 12, 2024 00:18
@divolgin divolgin force-pushed the divolgin/sc-110520/add-test-for-unauthenticated-200-response branch from b1e98ff to 7b89ab4 Compare September 12, 2024 00:19
.PHONY: pact-consumer
pact-consumer:
mkdir -p pacts/consumer && ( rm -rf pacts/consumer/* || : )
go test $(TEST_BUILDFLAGS) -v ./contracts/... || true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these "|| true" for safety since this cannot be tested until next release.

@divolgin divolgin merged commit f8692e2 into main Sep 12, 2024
117 checks passed
@divolgin divolgin deleted the divolgin/sc-110520/add-test-for-unauthenticated-200-response branch September 12, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants