Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run integration tests with ubuntu-latest to match embedded-cluster #4873

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

laverya
Copy link
Member

@laverya laverya commented Sep 9, 2024

What this PR does / why we need it:

The helmvm regression test is failing with a 'curl doesn't know this flag' error: https://github.com/replicatedhq/kots/actions/runs/10755567932/job/29827721257#step:8:2071

comes from Embedded Cluster, here: https://github.com/replicatedhq/embedded-cluster/blob/39eb313c03eeb27089f4cf3982a5353e39e46961/scripts/cache-files.sh#L61
which runs with ubuntu-latest while kots uses ubuntu-20.04
https://github.com/replicatedhq/embedded-cluster/blob/fd4ed73cfe2cafb818450393c23143d5fcdd327d/.github/workflows/ci.yaml#L169

So this bumps kots to use the same runner as Embedded Cluster here.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

@laverya laverya enabled auto-merge (squash) September 9, 2024 15:06
@laverya laverya merged commit b4c1bfa into main Sep 9, 2024
117 checks passed
@laverya laverya deleted the laverya/run-integration-tests-with-ubuntu-latest branch September 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants