-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved messaging when requested channel slug not allowed by license #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
reviewed
Aug 21, 2024
sgalsaleh
reviewed
Aug 23, 2024
sgalsaleh
reviewed
Aug 23, 2024
sgalsaleh
reviewed
Aug 23, 2024
sgalsaleh
reviewed
Aug 23, 2024
sgalsaleh
reviewed
Aug 23, 2024
Co-authored-by: Salah Al Saleh <[email protected]>
Co-authored-by: Salah Al Saleh <[email protected]>
sgalsaleh
reviewed
Sep 4, 2024
sgalsaleh
reviewed
Sep 4, 2024
sgalsaleh
reviewed
Sep 4, 2024
@sgalsaleh updated output:
|
sgalsaleh
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This improves the messaging when a requested channel slug is not allowed by a license, and explicitly inform's when we fall back to the "stable" channel. Theres up to 3 new log entries emitted:
No channel specified in upstream URI, falling back to channel "stable".
to explicitly signal we used the fallbackVerifying if channel slug "beta" allowed by license
to explicitly signal what slug we're looking forTo install/pull an allowed channel, use one of the following: appSlug/channelSlug
to indicate which would be allowed if there supplied channel slug was not allowedWhich issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/110998/improved-messaging-when-requested-channel-slug-not-allowed-by-license
Special notes for your reviewer:
Sample usage without a channel slug:
Sample usage with a channel slug thats not allowed:
Sample usage with a channel slug that IS allowed:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?