Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align loader spinner when the upgrade service is starting #4840

Merged

Conversation

miaawong
Copy link
Member

What this PR does / why we need it:

https://app.shortcut.com/replicated/story/108898/spinner-lags-and-changes-position-when-the-upgrade-service-is-starting
https://www.loom.com/share/1ea5e3c827b84a72b42a741c4bf04b4e

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Improve styles for the loader in the upgrade service

Does this PR require documentation?

@miaawong miaawong added type::bug Something isn't working bug::normal labels Aug 20, 2024
@miaawong miaawong force-pushed the miawong/sc-108898/spinner-lags-and-changes-position-when-the branch from a6746f6 to 36d98f6 Compare August 20, 2024 20:34
@miaawong miaawong marked this pull request as ready for review August 21, 2024 00:45
@miaawong miaawong requested a review from sgalsaleh August 21, 2024 00:46
@miaawong miaawong merged commit a0d1a56 into main Aug 22, 2024
111 checks passed
@miaawong miaawong deleted the miawong/sc-108898/spinner-lags-and-changes-position-when-the branch August 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants