Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrections in the default support bundle spec #4836

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Aug 20, 2024

What this PR does / why we need it:

  • Remove unnecessary outcome line
  • Fix syntax in nodeMetrics analyser

Before
https://asciinema.org/a/zPWymoUIGeuYrxC6Zgvqz1j5Y

After
https://asciinema.org/a/IB0VhRSLqWhkBj5uvXDsrcOwQ

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fix analyzers in support bundle spec missed due to syntax errors

Does this PR require documentation?

NONE

@banjoh banjoh changed the title chore: Remove unnecessary outcomes line from support bundle spec fix: Corrections in the default support bundle spec Aug 20, 2024
@banjoh banjoh force-pushed the em/fix-support-bundle-spec branch from 576254b to baed359 Compare August 20, 2024 11:17
@banjoh banjoh merged commit 92b9d47 into main Aug 21, 2024
111 checks passed
@banjoh banjoh deleted the em/fix-support-bundle-spec branch August 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants