Show join command during restore in Embedded Cluster #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaawong
force-pushed
the
miawong/sc-106757/show-a-dedicated-node-join-page-during-restores
branch
from
0e43624 to
a5b32af
Compare
miaawong
force-pushed
the
miawong/sc-106757/show-a-dedicated-node-join-page-during-restores
branch
from
a5b32af to
b54ca3b
Compare
sgalsaleh
reviewed
Aug 22, 2024
web/src/Root.tsx
Outdated
| @@ -501,6 +501,9 @@ const Root = () => { | |||
| isEmbeddedClusterEnabled={Boolean( | |||
| state.adminConsoleMetadata?.isEmbeddedCluster | |||
| )} | |||
| isEmbeddedClusterNodeWaiting={ | |||
There was a problem hiding this comment.
why not keep it the same name?
Suggested change
| isEmbeddedClusterNodeWaiting={ | |
| isEmbeddedClusterWaitingForNodes ={ |
miaawong
force-pushed
the
miawong/sc-106757/show-a-dedicated-node-join-page-during-restores
branch
from
468b772 to
baade34
Compare
sgalsaleh
reviewed
Aug 23, 2024
| </div> | ||
| )} | ||
| {Utilities.isInitialAppInstall(app) || | ||
| (isEmbeddedClusterWaitingForNodes && ( |
There was a problem hiding this comment.
shouldn't it be more like this:
{(Utilities.isInitialAppInstall(app) || isEmbeddedClusterWaitingForNodes) && (
<div>
...
</div>
)}
There was a problem hiding this comment.
youre right. ugh prettier works against me sometimes
sgalsaleh
previously approved these changes
Aug 23, 2024
miaawong
force-pushed
the
miawong/sc-106757/show-a-dedicated-node-join-page-during-restores
branch
from
7d7c40c to
85cb67b
Compare
miaawong
force-pushed
the
miawong/sc-106757/show-a-dedicated-node-join-page-during-restores
branch
from
85cb67b to
1b48567
Compare
sgalsaleh
approved these changes
Aug 30, 2024
miaawong
deleted the
miawong/sc-106757/show-a-dedicated-node-join-page-during-restores
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://app.shortcut.com/replicated/story/106757/show-a-dedicated-node-join-page-during-restores
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?