Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC upgrade UI: Fix type errors #4758

Merged
merged 2 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/components/UploadLicenseFile.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -508,13 +508,13 @@ const UploadLicenseFile = (props: Props) => {
<p className="u-fontSize--small u-textColor--bodyCopy u-lineHeight--normal u-marginBottom--10">
Select the application that you want to install.
</p>
{/* TODO: there's probably a bug here*/}
{/*@ts-ignore*/}
<Select
className="replicated-select-container"
classNamePrefix="replicated-select"
options={state.availableAppOptions}
getOptionLabel={(option) =>
// We want to display element instead of string
// @ts-ignore
getLabel(option.label)
}
getOptionValue={(option) => option.value}
Expand Down
17 changes: 13 additions & 4 deletions web/src/components/snapshots/SnapshotStorageDestination.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ type AWSStoreProvider = {
other?: undefined;
path?: string;
bucket?: string;
internal?: undefined;
fileSystem?: undefined;
};

type GCPStoreProvider = {
Expand All @@ -116,6 +118,8 @@ type GCPStoreProvider = {
azure?: undefined;
other?: undefined;
path?: undefined;
internal?: undefined;
fileSystem?: undefined;
};

type AzureStoreProvider = {
Expand All @@ -133,6 +137,8 @@ type AzureStoreProvider = {
gcp?: undefined;
other?: undefined;
path?: undefined;
internal?: undefined;
fileSystem?: undefined;
};

type OtherStoreProvider = {
Expand All @@ -148,6 +154,8 @@ type OtherStoreProvider = {
gcp?: undefined;
azure?: undefined;
path?: undefined;
internal?: undefined;
fileSystem?: undefined;
};

type StoreMetadata = {
Expand All @@ -156,8 +164,8 @@ type StoreMetadata = {
azure?: undefined;
other?: undefined;
bucket?: string;
internal?: boolean;
fileSystem?: string;
internal?: undefined;
fileSystem?: undefined;
path?: string;
};

Expand Down Expand Up @@ -1763,15 +1771,16 @@ class SnapshotStorageDestination extends Component<Props, State> {
)}
<div className="flex1">
{availableDestinations.length > 1 ? (
// TODO: upgrade react-select and use the current typing
// @ts-ignore
<Select
className="replicated-select-container"
classNamePrefix="replicated-select"
placeholder="Select unit"
options={availableDestinations}
isSearchable={false}
getOptionLabel={(destination) =>
// TODO: upgrade react-select and use the current typing
// We want to display element instead of string
// @ts-ignore
this.getDestinationLabel(
destination,
destination.label
Expand Down
Loading