Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kotsadm/rqlite image in migrations test #4227

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Dec 15, 2023

What this PR does / why we need it:

  • run tests against the actual rqlite image that will be used in production.
  • rqlite/rqlite will not have the same tags that we generate for our kotsadm/rqlite image

Which issue(s) this PR fixes:

Fixes SC-94750

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

cbodonnell
cbodonnell previously approved these changes Dec 15, 2023
cbodonnell
cbodonnell previously approved these changes Dec 15, 2023
@sgalsaleh sgalsaleh merged commit ec37bb7 into main Dec 15, 2023
163 checks passed
@sgalsaleh sgalsaleh deleted the fix-rqlite-image-in-migrations-test branch December 15, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants