Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Chainguard's minio, rqlite, and dex images #4191

Merged
merged 14 commits into from
Dec 4, 2023
Merged

Use Chainguard's minio, rqlite, and dex images #4191

merged 14 commits into from
Dec 4, 2023

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Nov 30, 2023 •
edited
Loading

What this PR does / why we need it:

Uses Chainguard's minio, rqlite, and dex images to get rid of CVEs. Mirrors Chainguard's images to our Dockerhub account to avoid asking end customers to add a new firewall rule for Chainguard's registry.

Which issue(s) this PR fixes:

Fixes SC-94077

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Does this PR require documentation?

NONE

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/KOTS-2023.12.2-4cd885-nightly-4191-merge-4cd885a-kotsadm-2023.12.2-4cd885-nightly-k8s-docker-2023-12-02T02:20:50Z

@sgalsaleh sgalsaleh marked this pull request as ready for review December 2, 2023 04:45
@sgalsaleh sgalsaleh requested a review from cbodonnell December 2, 2023 04:45
cbodonnell
cbodonnell approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@cbodonnell cbodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one thing i have a question about:

the build-ttl.sh make command still does a docker build. any reason this should or should not use the new build method?

@sgalsaleh sgalsaleh merged commit ad7d0ea into main Dec 4, 2023
164 checks passed
@sgalsaleh sgalsaleh deleted the use-chainguard-3rd-party-images branch December 4, 2023 14:58
sgalsaleh added a commit that referenced this pull request Dec 6, 2023
@sgalsaleh
Revert "Use Chainguard's minio, rqlite, and dex images (#4191)"
43ec621 
This reverts commit ad7d0ea.
sgalsaleh added a commit that referenced this pull request Dec 6, 2023
@sgalsaleh
Revert "Use Chainguard's minio, rqlite, and dex images (#4191)"
e4f6e89 
This reverts commit ad7d0ea.
sgalsaleh added a commit that referenced this pull request Dec 6, 2023
@sgalsaleh
Revert "Use Chainguard's minio, rqlite, and dex images (#4191)" (#4205)
72d34c8 
* Revert "Use Chainguard's minio, rqlite, and dex images (#4191)"

This reverts commit ad7d0ea.

* revert dex command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodonnell cbodonnell cbodonnell approved these changes

Assignees
No one assigned
Labels
type::security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgalsaleh @cbodonnell