Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update e2e nodejs install method #4173

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

cbodonnell
Copy link
Contributor

What this PR does / why we need it:

This PR updates the nodejs install method for the e2e dependencies. Previously it was using a deprecated install method that would display a warning for 60 seconds. This PR updates it to use the recommended install method per https://github.com/nodesource/distributions#installation-instructions.

repo_deprecation_warning() {
  print_bold_deprecation \
"                         ${underline}SCRIPT DEPRECATION WARNING${normal}                    " "\

  This script, located at ${bold}https://deb.nodesource.com/setup_X${normal}, used to
  install Node.js is deprecated now and will eventually be made inactive.

  Please visit the NodeSource ${bold}distributions${normal} Github and follow the
  instructions to migrate your repo.
  ${underline}${green}${bold}https://github.com/nodesource/distributions${normal}

  The ${bold}NodeSource${normal} Node.js Linux distributions GitHub repository contains
  information about which versions of Node.js and which Linux distributions
  are supported and how to install it.
  ${underline}${green}${bold}https://github.com/nodesource/distributions${normal}


                          ${underline}${bold}${yellow}SCRIPT DEPRECATION WARNING${normal}
"

        echo
        echo "${cyan}${bold}TO AVOID THIS WAIT MIGRATE THE SCRIPT${normal}"
        echo "Continuing in 60 seconds (press Ctrl-C to abort) ..."
        echo
        sleep 60
}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?


Does this PR require documentation?

@cbodonnell cbodonnell merged commit dbc8a38 into main Nov 27, 2023
161 checks passed
@cbodonnell cbodonnell deleted the cbo/e2e-nodejs-install-deprecation branch November 27, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants