Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CLI to validate minimal RBAC tests instead of testim #4126

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Nov 8, 2023

What this PR does / why we need it:

Uses the CLI to validate minimal RBAC tests instead of testim to reduce the number unnecessary testim tests.

Which issue(s) this PR fixes:

Fixes SC-93037

Special notes for your reviewer:

Image 2023-11-09 at 7 04 47 AM

Steps to reproduce

Does this PR introduce a user-facing change?

- Surfaces preflight check errors that are due to insufficient RBAC permissions to the CLI.

Does this PR require documentation?

NONE

@sgalsaleh sgalsaleh requested a review from cbodonnell November 8, 2023 21:17
cbodonnell
cbodonnell previously approved these changes Nov 8, 2023
cbodonnell
cbodonnell previously approved these changes Nov 9, 2023
@sgalsaleh sgalsaleh merged commit 8df2257 into main Nov 9, 2023
164 checks passed
@sgalsaleh sgalsaleh deleted the use-cli-to-validate-minimal-rbac-tests branch November 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants