chainguard Integration #4018
Merged
chainguard Integration #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
force-pushed
the
integration-chainguard
branch
from
3ef721a to
64cf502
Compare
sgalsaleh
force-pushed
the
integration-chainguard
branch
from
1450bca to
73a2cc0
Compare
cbodonnell
reviewed
Nov 22, 2023
sgalsaleh
force-pushed
the
integration-chainguard
branch
from
01bd440 to
ce9b1a2
Compare
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
imjasonh
reviewed
Nov 29, 2023
imjasonh
reviewed
Nov 29, 2023
|
|
||
| # Symlink the gcsfuse mount to ./packages/$arch/*.apk | ||
| mkdir -p ./packages/x86_64 | ||
| ln -s /tmp/gcsfuse/apk-repo/x86_64/*.apk ./packages/x86_64/ |
There was a problem hiding this comment.
Suggested change
| ln -s /tmp/gcsfuse/apk-repo/x86_64/*.apk ./packages/x86_64/ | |
| ln -s /tmp/gcsfuse/apk-repo/x86_64/*.apk ./packages/x86_64/ | |
| ln -s /tmp/gcsfuse/apk-repo/chainguard-enterprise.rsa.pub ./packages/ |
Also need to symlink the key into ./packages/. We should be able to see this in the ls -lR below if this is successful.
There was a problem hiding this comment.
Getting this error now (i only added the key to the melange config, not apko):
Error: failed to build package: unable to build guest: unable to create build context: initializing apk: failed to initialize apk keyring: failed to read apk key: open ./packages/chainguard-enterprise.rsa.pub: permission denied
2023/11/29 16:02:15 error during command execution: failed to build package: unable to build guest: unable to create build context: initializing apk: failed to initialize apk keyring: failed to read apk key: open ./packages/chainguard-enterprise.rsa.pub: permission denied
Error: Process completed with exit code 1.
cbodonnell
reviewed
Nov 30, 2023
|
|
||
| - name: Download kotsadm artifact | ||
| uses: actions/download-artifact@v3 | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
i think we just changed this to v4. any reason to change it back?
cbodonnell
reviewed
Nov 30, 2023
| uses: actions/checkout@v4 | ||
| - name: Download go_api artifact | ||
| uses: actions/download-artifact@v3 | ||
| uses: actions/checkout@v3 |
cbodonnell
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Uses Chainguard to build the
kotsadmimage for the PR, on merge, and release workflows.Which issue(s) this PR fixes:
Fixes:
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE