Make password secret optional #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createPasswordSecret defaults to true as to not break current behaviour
cbodonnell
reviewed
May 13, 2024
templates/kotsadm-statefulset.yaml
Outdated
Comment on lines
31
to
36
| {{- if .Values.passwordSecretRef }} | ||
| {{- with .Values.passwordSecretRef }} | ||
| key: {{ .key }} | ||
| name: {{ .name }} | ||
| {{- end }} | ||
| {{- else }} |
There was a problem hiding this comment.
I believe we will also need to somehow tell KOTS what this new secret name is as it updates it at runtime when the password is changed. The kotsadm-password name is currently hard-coded in a few places.
One example where it updates the secret: https://github.com/replicatedhq/kots/blob/v1.109.0/pkg/password/password.go#L80
cbodonnell
reviewed
May 13, 2024
cbodonnell
reviewed
May 14, 2024
Comment on lines
+28
to
+32
| {{- if .Values.passwordSecretRef }} | ||
| if kubectl get secret kotsadm-password -n {{ .Release.Namespace }} -o jsonpath='{.metadata.labels.app\.kubernetes\.io/managed-by}' | grep -q "Helm"; then | ||
| kubectl annotate secret kotsadm-password -n {{ .Release.Namespace }} helm.sh/resource-policy=keep | ||
| fi | ||
| {{- end }} |
There was a problem hiding this comment.
would this effectively keep the secret around, but it would no longer be used by KOTS? is there a reason why we want to keep it around? kinda thinking out loud here...
There was a problem hiding this comment.
I didn't think we're deprecating the secret entirely? just pre-generating the secret if needed from EC
cbodonnell
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new value:
passwordSecretReftakes a secret ref i.e:map[key, name]to tell kots what secret to use instead of the default.if set, it overrides password secret generation