Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure the nodeport is named admin-console #29

Merged
merged 1 commit into from
Dec 18, 2023
Merged

ensure the nodeport is named admin-console #29

merged 1 commit into from
Dec 18, 2023

Conversation

laverya
Copy link
Member

@laverya laverya commented Dec 18, 2023 •
edited
Loading

kotsadm relies on this to generate the node join command

@laverya laverya added bug Something isn't working bug::normal type::bug and removed bug Something isn't working labels Dec 18, 2023
chris-sanders
chris-sanders approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@chris-sanders chris-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup lgtm

@laverya laverya merged commit 722ef9a into main Dec 18, 2023
1 check passed
@laverya laverya deleted the laverya/return-kotsadm-nodeport-service-name branch December 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sanders chris-sanders chris-sanders approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laverya @chris-sanders