Don't scale down Longhorn pods before pvmigrate runs #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
previously approved these changes
Oct 9, 2023
laverya
approved these changes
Oct 9, 2023
diamonwiggins
deleted the
diamonwiggins/fix-longhorn-migration-pod-scaling-conflict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Today both kURL and Pvmigrate have code to scale down pods using Longhorn before a migration starts. Pvmigrate however contains additional code to determine where it should schedule a volume based on its attached workload which is relevant for migrations to OpenEBS LocalPV where the volumes can't be mounted to multiple nodes. This change leaves pod scale down operations to Pvmigrate so that it can also make determinations based on where existing workloads were running when scheduling the migration pod that creates new volumes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?