Skip to content

Commit

Permalink
chore: inform users that 15% of the root disk is reserved (#4914)
Browse files Browse the repository at this point in the history
* chore: inform users that 15% of the root disk is reserved

when evaluating the amount of free disk space to migrate to openebs we
reserve 15% of the disk for the operating system (avoid kubernetes
triggering of its clean up unused images routine). we haven't been
informing users of that causing confusion on why the available + used
amounts did not add up to the full root disk size.

* chore: rephrasing user visible message

* chore: rephrasing user visible message
  • Loading branch information
ricardomaraschini authored Oct 26, 2023
1 parent d8d5138 commit 11baa0a
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion pkg/cluster/space/openebs_disk_space_validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,19 @@ func (o *OpenEBSDiskSpaceValidator) NodesWithoutSpace(ctx context.Context) ([]st
continue
}

var reservedMsg string
if vol.RootVolume {
reservedMsg = "(15% of the root disk is reserved to prevent DiskPressure evictions)"
}

faultyNodes[node] = true
o.log.Printf(
"Node %q has %s available, which is less than the %s that would be migrated from the %q storage class",
"Node %q has %s available, which is less than the %s that would be migrated from the %q storage class %s",
node,
bytefmt.ByteSize(uint64(free)),
bytefmt.ByteSize(uint64(reservedPerNode[node])),
o.srcSC,
reservedMsg,
)
}

Expand Down

0 comments on commit 11baa0a

Please sign in to comment.