fix HA cluster upgrades #798
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
…ti-node-ha-upgrades-do-not-work
…ti-node-ha-upgrades-do-not-work
| obj.ObjectMeta.Labels = applySeaweedFSLabels(obj.ObjectMeta.Labels, "s3") | ||
|
|
||
| err := cli.Create(ctx, obj) | ||
| if err != nil { |
There was a problem hiding this comment.
| if err != nil { | |
| if err != nil && !k8serrors.IsAlreadyExists(err) { |
There was a problem hiding this comment.
I think failing if it already exists here is actually desired - this migration should only be run once, and if the resource already exists that means it's being run in parallel
There was a problem hiding this comment.
what if creating the seaweed resources succeeded but creating the registry resources failed, so the HA field didn't get updated in the installation object. then it will always fail on retry unless the resource gets deleted manually.
| obj.ObjectMeta.Labels = applySeaweedFSLabels(obj.ObjectMeta.Labels, "s3") | ||
|
|
||
| err = cli.Create(ctx, obj) | ||
| if err != nil { |
There was a problem hiding this comment.
| if err != nil { | |
| if err != nil && !k8serrors.IsAlreadyExists(err) { |
| obj.ObjectMeta.Labels = applySeaweedFSLabels(obj.ObjectMeta.Labels, "s3") | ||
|
|
||
| err = cli.Create(ctx, obj) | ||
| if err != nil { |
There was a problem hiding this comment.
| if err != nil { | |
| if err != nil && !k8serrors.IsAlreadyExists(err) { |
…ti-node-ha-upgrades-do-not-work
* updated embeddedclusteroperator version * Update values.yaml * Update values.yaml --------- Co-authored-by: laverya <[email protected]> Co-authored-by: Andrew Lavery <[email protected]>
No description provided.