Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kinds): merge into mono repo #1075

Merged
merged 118 commits into from
Sep 3, 2024

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Aug 30, 2024

What this PR does / why we need it:

Merges kinds repo into ec

https://github.com/replicatedhq/airgap/pull/189
replicatedhq/kots#4854

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

sgalsaleh and others added 30 commits March 6, 2024 10:31
add embedded cluster release metadata type
- added a state to indicate we are copying artifacts to nodes.
- bump controller-gen to the latest stable version.
…mplement-local-artifact-mirror

feat: adding a new installation state
…tadata-override

add metadataOverride to installation kind
…ded-cluster-binary-name

add 'BinaryName' field to the installation type
…to-ec

add various types to support velero/snapshots in EC
…to-ec

remove velero enable/disable config option
starts to automatically create prs for dependabot detected outdated dependencies.
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.17.2 to 0.17.3.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.17.2...v0.17.3)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…8s.io/controller-runtime-0.17.3

Bump sigs.k8s.io/controller-runtime from 0.17.2 to 0.17.3
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.29.2 to 0.30.0.
- [Commits](kubernetes/apimachinery@v0.29.2...v0.30.0)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…/apimachinery-0.30.0

Bump k8s.io/apimachinery from 0.29.2 to 0.30.0
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.12.3 to 3.14.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.12.3...v3.14.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…h/helm/v3-3.14.3

Bump helm.sh/helm/v3 from 3.12.3 to 3.14.3
introduces properties needed to allow users to override the default
values.yaml used for our builtin add-ons.
@emosbaugh emosbaugh changed the title Emosbaugh/20240830/move kinds into repo chore(kinds): merge into mono repo Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-9ae651d" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-9ae651d?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@emosbaugh emosbaugh force-pushed the emosbaugh/20240830/move-kinds-into-repo branch from bbfa259 to 9ae651d Compare August 30, 2024 20:24
@emosbaugh emosbaugh marked this pull request as ready for review August 30, 2024 20:28
Comment on lines +7 to +14
## Publishing kinds

To publish a new version of the github.com/replicatedhq/embedded-cluster/kinds package, tag and push to with the format `kinds/v1.0.0` with a leading `v`.
This is a Go feature. See the docs on [Multi-Module Repositories](https://go.dev/wiki/Modules#faqs--multi-module-repositories) for more information.

```bash
git tag -a kinds/v1.0.0 -m "Release v1.0.0"
git push origin kinds/v1.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

- name: Unit tests
run: make -C kinds unit-tests

validate-success:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add branch protection

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might need to be a different name, not sure (current 'ci' workflow also has a 'validate-success' job)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill follow up with another pr if it does

@laverya
Copy link
Member

laverya commented Aug 30, 2024

If we merge embedded-cluster-kinds into EC, will kots be able to import things properly still?

@emosbaugh emosbaugh requested review from laverya and sgalsaleh August 30, 2024 21:56
@emosbaugh
Copy link
Member Author

If we merge embedded-cluster-kinds into EC, will kots be able to import things properly still?

@laverya It seems to work
replicatedhq/kots#4854

@emosbaugh emosbaugh merged commit 843444f into main Sep 3, 2024
57 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/20240830/move-kinds-into-repo branch September 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants