This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
fix: k8s upgrades not working in airgapped environments #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
commented
Jul 29, 2024
emosbaugh
force-pushed
the
emosbaugh/sc-109434/fix-upgrade-tests
branch
2 times, most recently
from
62cb667 to
671e55a
Compare
emosbaugh
commented
Jul 30, 2024
| // if we are running in an airgap environment all assets are already present in the | ||
| // node and are served by the local-artifact-mirror binary listening on localhost | ||
| // port 50000. we just need to get autopilot to fetch the k0s binary from there. | ||
| k0surl = "http://127.0.0.1:50000/bin/k0s-upgrade" |
There was a problem hiding this comment.
this was missing from the original refactor
emosbaugh
commented
Jul 30, 2024
| // the one that copies the artifacts to the nodes and the second one is the one that | ||
| // actually upgrades the k0s version. we need to make sure that this is the second plan | ||
| // before setting the installation state to the plan state. | ||
| if isAutopilotUpgradeToVersion(&plan, desiredVersion) { |
There was a problem hiding this comment.
this was needed otherwise an upgrade was never attempted as it would set the status to kubernetesinstalled based on the distribute airgap artifacts plan. the rest is just moving some code around.
emosbaugh
force-pushed
the
emosbaugh/sc-109434/fix-upgrade-tests
branch
from
4a56513 to
2daee23
Compare
emosbaugh
changed the title
ricardomaraschini
approved these changes
Jul 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.