This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
feat: build operator image with chainguard #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
reviewed
Jul 16, 2024
sgalsaleh
reviewed
Jul 16, 2024
sgalsaleh
reviewed
Jul 16, 2024
sgalsaleh
reviewed
Jul 16, 2024
| - name: Build linux-amd64 | ||
| run: | | ||
| make build | ||
| name: manager |
There was a problem hiding this comment.
hmm, thinking about this, the binary in the image will be CVE free, but this is the one that will end up in production and used by kots. i worked around a similar situation with the schemahero binary and the kotsadm-migrations image in kots by extracting the binary from the image published by apko: https://github.com/replicatedhq/kots/blob/main/.github/actions/build-custom-melange-package/action.yml#L44-L45
emosbaugh
force-pushed
the
emosbaugh/sc-108755/use-chainguard-images-for-embedded-cluster
branch
from
1814af0 to
4adf5c1
Compare
sgalsaleh
reviewed
Jul 16, 2024
sgalsaleh
approved these changes
Jul 16, 2024
sgalsaleh
deleted the
emosbaugh/sc-108755/use-chainguard-images-for-embedded-cluster
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds images with chainguard (melange and apko)
https://github.com/replicatedhq/embedded-cluster-operator/releases/tag/v0.40.2-build.1