Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match size with the output #482

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

weilirs
Copy link
Collaborator

@weilirs weilirs commented Nov 12, 2024

Updated:
image

@weilirs weilirs requested a review from samlhuillier November 12, 2024 02:32
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Changed the ConversationHistory component's container height property to maxHeight for improved responsive behavior when content is smaller than the maximum size.

  • Modified style property in /src/components/WritingAssistant/ConversationHistory.tsx from fixed height to maxHeight for better container flexibility
  • Container now properly shrinks with less content while maintaining the upper size boundary
  • Scrolling behavior remains intact with existing overflow-y-auto class

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@weilirs
Copy link
Collaborator Author

weilirs commented Nov 13, 2024

also fixate the size of the writing assistant's window to avoid it being too large and overflow like
image

@samlhuillier samlhuillier merged commit 298947b into reorproject:main Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants