Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update application setup guide for deploio #386

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update application setup guide for deploio #386

wants to merge 11 commits into from

Conversation

CuddlyBunion341
Copy link
Contributor

No description provided.

@CuddlyBunion341 CuddlyBunion341 self-assigned this Sep 30, 2024
@CuddlyBunion341 CuddlyBunion341 changed the title Update go live section for deploio Update application setup guide for deploio Sep 30, 2024
@CuddlyBunion341 CuddlyBunion341 marked this pull request as draft September 30, 2024 07:54
@CuddlyBunion341 CuddlyBunion341 marked this pull request as ready for review October 2, 2024 07:15
coorasse
coorasse reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some points

go_live.md Outdated Show resolved Hide resolved
ruby_on_rails/create_application_server.md Show resolved Hide resolved
ruby_on_rails/environment_protection.md Outdated Show resolved Hide resolved
ruby_on_rails/rspec.md
@@ -126,11 +126,21 @@ Commit and push your changes! :tada:

## Verify

Check that you see a green page in each app.

### Heroku
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check should be done also for deplo.io, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is also described in the ### Deploio section. The difference is that the application urls are generated and can be retrieved using the nctl cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coorasse coorasse coorasse left review comments

@schmijos schmijos Awaiting requested review from schmijos

At least 1 approving review is required to merge this pull request.

Assignees

@CuddlyBunion341 CuddlyBunion341

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CuddlyBunion341 @coorasse