feat(datasource): add Hackage datasource #32944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
requested changes
Dec 9, 2024
secustor
reviewed
Dec 11, 2024
Co-authored-by: Sebastian Poxhofer <[email protected]>
secustor
requested changes
Dec 12, 2024
Co-authored-by: Sebastian Poxhofer <[email protected]>
Co-authored-by: Sebastian Poxhofer <[email protected]>
|
OK, I have again addressed all comments |
secustor
approved these changes
Dec 12, 2024
|
🎉 This PR is included in version 39.64.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
reviewed
Dec 14, 2024
| } | ||
| } | ||
|
|
||
| export function versionToRelease( |
There was a problem hiding this comment.
these functions should usually not public. they should be in a utils or common files if separate tests are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Following the addition of PVP in #32298, this adds a datasource for fetching versions from Hackage, the Haskell package repository.
Context
The Hackage datasource will enable Renovate to determine available versions for a given package name.
See discussion on #31493.
I have improved documentation of the endpoint used:
This API is already available on deployed Hackage instances, but the documentation will be visible in the API docs only at a later time when a deployment is made.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
I have tested this with a manager for
.cabalfiles that I have drafted.(which I purposefully haven't included it in this PR)
However, it should also be possible to use this functionality e.g. on Hpack
dependency listings with a custom manager.