refactor(bundler): refactor extraction regexes #32870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djiit
commented
Dec 3, 2024
Djiit
commented
Dec 3, 2024
rarkins
reviewed
Dec 3, 2024
rarkins
approved these changes
Dec 4, 2024
secustor
approved these changes
Dec 4, 2024
SuperSandro2000
added a commit
to SuperSandro2000/renovate
that referenced
this pull request
Dec 5, 2024
* upstream/main: (95 commits) fix(presets): use regex to match versions for :automergeStableNonMajor preset (renovatebot#32924) feat(bazel-module): add support for oci.pull (renovatebot#32453) fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.1.0 (renovatebot#32925) fix(bundler): gracefully ignore internal packages (renovatebot#32923) docs: list uv.lock as supported by lockFileMaintenance. (renovatebot#32897) chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.1.0 (renovatebot#32920) refactor(bundler): refactor extraction regexes (renovatebot#32870) chore(deps): update dependency @types/node to v20.17.9 (renovatebot#32916) chore(deps): update python:3.13 docker digest to 220d075 (renovatebot#32914) chore(deps): update python:3.13 docker digest to 30fca17 (renovatebot#32912) chore(deps): update python docker tag to v3.13.1 (renovatebot#32913) fix(docs): typos (renovatebot#32888) chore(deps): update otel/opentelemetry-collector-contrib docker tag to v0.115.1 (renovatebot#32911) fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.14.1 (renovatebot#32910) fix(metadata): update changelog URL for mypy (renovatebot#32106) chore(deps): update dependency type-fest to v4.29.0 (renovatebot#32902) chore(deps): update python:3.13 docker digest to e95be02 (renovatebot#32900) docs(faq): mention weekly update goal for Mend Renovate app (renovatebot#32899) feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.14.0 (renovatebot#32896) chore(deps): update python:3.13 docker digest to 7861d60 (renovatebot#32895) ...
|
🎉 This PR is included in version 39.50.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Break the line regex into mutliple one. Instead of capturing all the line at once, we ensure it's a
gemline, then apply other regexes sequentially. A few benefits:gem 'foo', source: baz, require: 'bar'andgem 'foo', require: 'bar', source: bazare now parsed the same wayCurrent tests are still passing.
Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: