Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(env): pass additional ssl and url replace env to child process #23887

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat(env): pass additional ssl and url replace env to child process #23887

merged 1 commit into from
Aug 16, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 16, 2023 •
edited
Loading

Changes

  • Pass SSL certificate environment variables to child process
  • Pass containerbase url replacement variables to child process

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins August 16, 2023 08:21
@viceice viceice added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 0d0ab69 Aug 16, 2023
34 checks passed
@viceice viceice deleted the feat/extra-env branch August 16, 2023 08:42
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass URL_REPLACE_ to child process.
3 participants
@viceice @renovate-release @rarkins