feat(module): improve param validation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiintbrisson
force-pushed
the
feat/improve-module-param-validation
branch
from
d36b49e to
7da41fc
Compare
saiintbrisson
force-pushed
the
feat/improve-module-param-validation
branch
2 times, most recently
from
b411643 to
78872cc
Compare
aripiprazole
approved these changes
Mar 24, 2024
This commit changes how we validate module params, making it impossible to create invalid addresses, names, or repeated names when updating an existing module. The checks are now in one place.
saiintbrisson
force-pushed
the
feat/improve-module-param-validation
branch
from
78872cc to
a89bd83
Compare
functor-flow
pushed a commit
that referenced
this pull request
Jan 16, 2025
This commit changes how we validate module params, making it impossible to create invalid addresses, names, or repeated names when updating an existing module. The checks are now in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how we validate module params, making it impossible to create invalid addresses, names, or repeated names when updating an existing module. The checks are now in one place.