Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac(pallets/subspace): remove useless code from test_ownership_ratio #27

Closed
wants to merge 1 commit into from
Closed

refac(pallets/subspace): remove useless code from test_ownership_ratio #27

wants to merge 1 commit into from

Conversation

aripiprazole
Copy link
Member

No description provided.

saiintbrisson
saiintbrisson reviewed Mar 8, 2024
View reviewed changes
Copy link

@saiintbrisson saiintbrisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to understand if we should create asserts to the removed variables

@aripiprazole
Copy link
Member Author

it would be good to understand if we should create asserts to the removed variables

we can discuss this on discord on monday

@saiintbrisson saiintbrisson deleted the refac/remove-printlns-from-delegating-tests branch June 13, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiintbrisson saiintbrisson saiintbrisson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aripiprazole @saiintbrisson