Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dockerfile): fix "Github deploy key chmod" logic #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chodonne
Copy link
Contributor

When no Github deployment key was provided, the Docker build would try to perform a chmod on a file that doesn't exist.

This moves the chmod command into the if statement, so it should only run if there is a Github deploy key available

@chodonne
Copy link
Contributor Author

Looks like moving the chmod statement to be out of the if statement in the parent commit was intentional. If so, please ignore this PR. Just curious the reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant