renegade_contracts: darkpool: align parameterize_circuit & add_circuit functions #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
approved these changes
Sep 1, 2023
akirillo
deleted the
andrew/align-darkpool-interface-with-multiverifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the same function selectors (
parameterize_circuit,add_circuit) on the darkpool as on the verifier.The former is for consistency, the latter is to ensure that we can actually add circuits to the darkpool contract. However, since the function on the darkpool accepts a
Circuitenum as a parameter instead acircuit_idfelt, it means that in practice, adding a circuit to the darkpool would first entail upgrading the darkpool (after having added the new circuit as a variant to the enum), and then callingadd_circuit. I think this is fine though, for the sake of readability and type safety around circuit variants.Cairo & e2e tests pass.