Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algebra: poly: poly, authenticated-poly: Implement polynomial division methods #26

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

joeykraut
Copy link
Member

Purpose

This PR implements polynomial division on both public and shared polynomials. In both cases, this is floor division. For shared polynomials, both parties can locally compute the division operation when the divisor is public -- this generates secret shares of the quotient polynomial as explained in the code.

Testing

  • All unit and integration tests pass
  • Tested all new arithmetic operations

@joeykraut joeykraut marked this pull request as ready for review October 12, 2023 21:50
@joeykraut joeykraut requested a review from akirillo October 12, 2023 21:50
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly questions that i trust you to have considered, but there are a couple small changes (i think) that are necessary

src/algebra/poly/poly.rs Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Outdated Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Outdated Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Show resolved Hide resolved
@joeykraut joeykraut requested a review from akirillo October 13, 2023 00:16
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for answering the qs, lgtm now!

@joeykraut joeykraut merged commit 3835d29 into joey/polynomials Oct 13, 2023
4 checks passed
@joeykraut joeykraut deleted the joey/poly-division branch October 13, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants