algebra: authenticated-poly: Implement scalar multiplication #248
Annotations
17 errors and 5 warnings
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/fabric.rs#L1074
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/fabric.rs:1074:49
|
1074 | let left_right = left.into_iter().chain(right.into_iter()).collect_vec();
| ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:523:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
use of `or_insert_with` to construct default value:
src/fabric/executor.rs#L345
error: use of `or_insert_with` to construct default value
--> src/fabric/executor.rs:345:14
|
345 | .or_insert_with(Vec::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/fabric/executor.rs#L309
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/fabric/executor.rs:309:26
|
309 | .zip(output.into_iter())
| ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `output`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/scalar/authenticated_scalar.rs#L379
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/scalar/authenticated_scalar.rs:379:18
|
379 | .zip(commitment_checks.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `commitment_checks`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/scalar/authenticated_scalar.rs#L102
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/scalar/authenticated_scalar.rs:102:18
|
102 | .zip(values_macs.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `values_macs`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/mpc_curve.rs#L539
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/mpc_curve.rs:539:26
|
539 | .zip(points.into_iter())
| ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `points`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/mpc_curve.rs#L366
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/mpc_curve.rs:366:26
|
366 | .zip(rhs_points.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `rhs_points`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/mpc_curve.rs#L238
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/mpc_curve.rs:238:26
|
238 | .zip(rhs_points.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `rhs_points`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/mpc_curve.rs#L105
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/mpc_curve.rs:105:26
|
105 | .zip(party1_values.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `party1_values`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/curve.rs#L509
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/curve.rs:509:26
|
509 | .zip(b.into_iter())
| ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/curve.rs#L477
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/curve.rs:477:22
|
477 | .zip(b.into_iter())
| ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/curve.rs#L344
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/curve.rs:344:22
|
344 | .zip(b.into_iter())
| ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/curve.rs#L258
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/curve.rs:258:22
|
258 | .zip(b.into_iter())
| ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/authenticated_curve.rs#L376
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/authenticated_curve.rs:376:18
|
376 | .zip(commitment_checks.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `commitment_checks`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/algebra/curve/authenticated_curve.rs#L101
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/algebra/curve/authenticated_curve.rs:101:18
|
101 | .zip(macs.into_iter())
| ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `macs`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d06ca0ffaf4ac72732665f99dd9ad962194cd0b3/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
variable does not need to be mutable:
src/fabric/executor.rs#L218
error: variable does not need to be mutable
--> src/fabric/executor.rs:218:21
|
218 | let mut operation = self.operations.get_mut(*op_id).unwrap();
| ----^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `-D unused-mut` implied by `-D warnings`
|
ambiguous glob re-exports:
src/algebra/mod.rs#L12
error: ambiguous glob re-exports
--> src/algebra/mod.rs:12:9
|
12 | pub use curve::*;
| ^^^^^^^^ the name `test_helpers` in the type namespace is first re-exported here
13 | pub use scalar::*;
| --------- but the name `test_helpers` in the type namespace is also re-exported here
|
= note: `-D ambiguous-glob-reexports` implied by `-D warnings`
|
format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|