use stream.opened instead of stream.connection #66
Conversation
Tadwork
force-pushed
the
fix-websocket-error-in-tail
branch
from
ae97f64 to
89abf36
Compare
Tadwork
force-pushed
the
fix-websocket-error-in-tail
branch
from
89abf36 to
9aedc24
Compare
|
What's the ETA of this MR review? Not being able to install the CLI for weeks is quite an issue... |
|
+1 Please can we get this reviewed and merged? |
| @@ -51,5 +51,5 @@ Deno.test('findUp', async (t) => { | |||
| assertEquals(ret, null); | |||
| }); | |||
|
|
|||
| Deno.remove(root, { recursive: true }); | |||
| await Deno.remove(root, { recursive: true }); | |||
There was a problem hiding this comment.
@shawn-render added this to fix the flaky test runs because otherwise the tests would fail in many cases with
findUp => ./util/find-up.test.ts:10:6
error: Leaking async ops:
- 1 async operation to op_fs_remove_async was started in this test, but never completed. The operation was started here:
at handleOpCallTracing (ext:core/01_core.js:610:42)
at Object.opAsync (ext:core/01_core.js:603:15)
at Object.remove (ext:deno_fs/30_fs.js:199:14)
at file:///Users/tzvifriedman/dev/render-cli/util/find-up.test.ts:54:8
at eventLoopTick (ext:core/01_core.js:183:11)
at async innerWrapped (ext:cli/40_testing.js:544:5)
at async asyncOpSanitizer (ext:cli/40_testing.js:193:27)
at async resourceSanitizer (ext:cli/40_testing.js:426:25)
at async exitSanitizer (ext:cli/40_testing.js:475:27)
at async outerWrapped (ext:cli/40_testing.js:489:14)
There was a problem hiding this comment.
Thank you! I was just looking into that too but you beat me to it 😄
|
@shawn-render I removed the check for |
| @@ -59,7 +59,7 @@ export const servicesTailCommand = | |||
| let writer: WritableStreamDefaultWriter<string | Uint8Array>; | |||
|
|
|||
| try { | |||
| conn = await stream.connection; | |||
| conn = await stream.opened; | |||
There was a problem hiding this comment.
@shawn-render I removed the check for stream.connection since it was failing the compile stage. The previous check was unnecessary since the compile stage will bundle the appropriate version of Deno anyway
Deno changed the
WebSocketStreamAPI to rename theconnectionproperty toopened. This proposed change would add a quick check to see which version of the API is in use and use the appropriate property. This should fix render-oss/homebrew-render#12deno task run services tail --id XXXXXXXto ensure that tails works as expected with the check