-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing page for widget #69
Conversation
@DougReeder thanks for doing this 🙏🏽 I'd like to also take a closer look but will have space only next week as I'm currently in podcast mode and also travelling. Looking forward to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Getting Started page could have a more clear sequence of steps (not sure how the points relate linearly) or maybe a more 'welcoming' vibe, but this is definitely more friendly and informative than the servers page.
get.md
Outdated
- If a friend or administrator has set up an account for you, get the details from them. | ||
- [5apps](https://5apps.com/storage/beta) is a commercial | ||
remoteStorage provider that currently offers free storage accounts. | ||
2. If you navigated here from an app, it's waiting for you in another tab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DougReeder could you explain a bit what this use case in 2. is referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- User navigates to RS webapp
- User clicks "Connect your storage"
- User clicks "Need help?"
- User creates account on 5apps or elsewhere. Successful signup ends on a page with a message such as "You've signed up. Thanks, username" (Armadietto) or something analogous for 5apps.
Ideal result: user has link back to original app (analogous to OAuth flow)
Actual result: user must remember they were creating the account for an app and which browser tab it's in.
This is a high-friction experience, in a world of lower-friction experiences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, seems like it's referring to the moment at point 4. I've re-worded it to feel more like a concrete step the person can take.
There's definitely friction there but it comes from not having a centralized place to create accounts. If people will always sign up at a host of their choosing, the app cannot suggest or maintain a link back. One possibility could be to pass the referring url onto each of the server links from the /get
page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This already looks much more welcoming to me than being thrown on a "servers" page.
I think what's missing is one sentence before the "Getting Started" to explain that the app they came from allows them to use their own storage account and that this 👇 is how to get started. WDYT?
@raucao @DougReeder just added that in the last commit. I made PR #72 with even more explanations, I think it's helpful. |
ac1560e
to
57d354e
Compare
The emoji and rewording help! I'd prefer to tighten it up, by replacing "Here are the steps..." with "Welcome!" and deleting "A more extensive list of options..." (The Servers page can still be accessed from the navigation). But if you want to go with this wording, I'm okay with it. |
I guess this is a stylistic thing (small versus large commits) but I think it's nice to have the option for both legible on GitHub (without needing the command line) for GUI people like me. I always imagined pull requests as a sort of 'large commit' and smaller commits inside to denote the traceable steps involved in changes… But it's your pull request, so as you wish. IMO this is ready to merge so I'll leave it to @raucao to take final look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@DougReeder I agree with @rosano about leaving the commit history intact, even when there are a lot of small commits. Force-pushing to a shared branch can also create other problems in general. If you really want to squash the commits into one, you can do that by selecting the option from the merge button menu on GitHub, at the time of merging the PR ("Squash and merge").
BTW I deleted a comment because they contained email addresses.
… |
for someone who is trying to get started with an app, and doesn't care about wider issues (yet)
Implements #18