Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typecheck script to react-router-dev #12294

Merged
merged 1 commit into from
Nov 15, 2024
Merged

add typecheck script to react-router-dev #12294

merged 1 commit into from
Nov 15, 2024

Conversation

pcattori
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a1e20ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori force-pushed the pedro/typecheck-react-router-dev branch from 87397b5 to a1e20ca Compare November 15, 2024 19:20
pcattori
pcattori commented Nov 15, 2024
View reviewed changes
packages/react-router-dev/cli/commands.ts
root ??= process.cwd();

if (flags.watch) {
await Typegen.watch(root, flags.config);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typechecking was failing here due to unwanted 2nd arg, so I also ripped out the obsolete config flag as part of this.

@pcattori pcattori merged commit 4b4bf59 into dev Nov 15, 2024
7 of 8 checks passed
@pcattori pcattori deleted the pedro/typecheck-react-router-dev branch November 15, 2024 19:51
pcattori added a commit that referenced this pull request Nov 15, 2024
@pcattori
Revert "add typecheck script to react-router-dev (#12294)"
7037a1d 
This reverts commit 4b4bf59.
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pcattori