Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define vm_emiAll as sum over vm_emiAllMkt and ... #1928

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

laurinks
Copy link
Contributor

@laurinks laurinks commented Dec 12, 2024

… ensure consistent use of vm_emiAll in 45_carbonprice/functionalForm/postsolve.gms

Purpose of this PR

See Mattermost exchange for background

  • Correct error in computation of vm_emiAll
  • Make sure that 45_carbonprice/functionalForm/postsolve.gms only uses vm_emiAll for CO2 budget computation.

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here: /p/tmp/laurinko/hpc/remind/output/SSP2-PkBudg650_2024-12-12_11.36.21
  • Comparison of results (what changes by this PR?): /p/tmp/laurinko/hpc/remind/compScen-develop-vs-release3p4-2024-12-12_14.50.29-H12.pdf (SSP2-PkBudg650.1: release version 3.4.0, SSP2-PkBudg650: new runs including changes)

…f vm_emiAll in 45_carbonprice/functionalForm/postsolve.gms
Copy link
Contributor

@fschreyer fschreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@laurinks
Copy link
Contributor Author

@Renato-Rodrigues : Would you like to have a look or can I merge based on Felix feedback?

@laurinks laurinks merged commit 477b59b into remindmodel:develop Dec 13, 2024
2 checks passed
@laurinks laurinks deleted the total-emissions branch December 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants