Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use piamenv::installDeps #1912

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

pascal-sauer
Copy link
Contributor

@pascal-sauer pascal-sauer commented Dec 5, 2024

Purpose of this PR

To streamline the (coupling) tests that I run before each magpie relase I pulled out the code to install magpie deps into piamenv::installDeps. This way magpie deps can already be installed before submitting a slurm job which runs the coupling tests (which then have no internet connection). piamenv::installDeps is now called after ensureRequirementsInstalled to ensure [email protected] is installed first.

Type of change

  • Refactoring
  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

Copy link
Contributor

@dklein-pik dklein-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pascal-sauer pascal-sauer merged commit 0d51437 into remindmodel:develop Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants