Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camp scens remind #1453

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Camp scens remind #1453

merged 6 commits into from
Nov 30, 2023

Conversation

jmuessel
Copy link
Contributor

@jmuessel jmuessel commented Nov 2, 2023

Purpose of this PR

Add two additional demand scenarios for CAMPAIGners with different levels of lifestyle changes:

gdp_SSP2EU_CAMP_weak: low ambition lifestyle changes
gdp_SSP2EU_CAMP_strong: high ambition lifestyle changes

This PR corresponds with:
EDGET: pik-piam/edgeTransport#230
MRREMIND: pik-piam/mrremind#440

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Calibration runs are here: /p/tmp/jaruschm/remind/output
  • Comparison of results (what changes by this PR?):

Copy link
Contributor

@robinhasse robinhasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jarusch, looking good!

@jmuessel jmuessel merged commit d81700e into remindmodel:develop Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants